simplify and comment dangling comma handling

2022-07-31 21:29:50 +02:00 · 2022-07-31 21:29:50 +02:00 · 60db35096f
commit 60db35096f
parent ab09d15703
1 changed files with 2 additions and 4 deletions
--- a/Library/Homebrew/rubocops/lines.rb
+++ b/Library/Homebrew/rubocops/lines.rb
@ -527,10 +527,8 @@ module RuboCop
          offending_node(offenses.last)
          replacement = if (%w[:bash :zsh :fish] - shells).empty?
            @offensive_node.source.sub(/shells: \[(:bash|:zsh|:fish)\]/, "")
-                           .gsub(",,", ",")
-                           .sub(", )", ")")
-                           .sub("(, ", "(")
-                           .sub("()", "")
+                           .sub(", )", ")") # clean up dangling trailing comma
+                           .sub("(, ", "(") # clean up dangling leading comma
          else
            @offensive_node.source.sub(/shells: \[(:bash|:zsh|:fish)\]/,
                                       "shells: [#{shells.join(", ")}]")