From 60914a3f4fab2fed8ab95446ec9d0c8fc5b2cb3b Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Sun, 4 Feb 2024 14:34:30 +0100 Subject: [PATCH] rubocops/cask: fix style --- .../Homebrew/rubocops/cask/shared_filelist_glob.rb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb b/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb index 27760781ed..170d3e1e5f 100644 --- a/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb +++ b/Library/Homebrew/rubocops/cask/shared_filelist_glob.rb @@ -8,22 +8,23 @@ module RuboCop extend AutoCorrector def on_send(node) - return unless node.method_name == :zap + return if node.method_name != :zap node.each_descendant(:pair).each do |pair| symbols = pair.children.select(&:sym_type?).map(&:value) next unless symbols.include?(:trash) pair.each_descendant(:array).each do |array| - regex = /sfl\d"$/ + message = "Use a glob (*) instead of a specific version (ie. sfl2) for trashing Shared File List paths" array.children.each do |item| - next unless item.source.match?(regex) + next unless item.source.match?(regex) - corrected_item = item.source.sub(/sfl\d"$/, "sfl*\"") + corrected_item = item.source.sub(/sfl\d"$/, "sfl*\"") - add_offense(item, message: "Use a glob (*) instead of a specific version (ie. sfl2) for trashing Shared File List paths") do |corrector| + add_offense(item, + message: message) do |corrector| corrector.replace(item, corrected_item) end end