admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/contributions: Use --repos=all not a separate --all flag

Browse Source
This commit is contained in:
Issy Long 2022-07-28 12:00:27 +01:00
parent be08b773f1
commit 5fa192c261
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/dev-cmd/contributions.rb
View File

@ -29,14 +29,10 @@ module Homebrew
flag "--to=", flag "--to=",
description: "Date (ISO-8601 format) to stop searching contributions." description: "Date (ISO-8601 format) to stop searching contributions."
flag "--all",
description: "Show contributions across all official Homebrew formula, cask and command repos."
comma_array "--repos=", comma_array "--repos=",
description: "The Homebrew repositories to search for contributions in. " \ description: "The Homebrew repositories to search for contributions in. " \
"Comma separated. Supported repos: #{SUPPORTED_REPOS.join(", ")}." "Comma separated. Pass `all` to search all repos. " \
"Supported repos: #{SUPPORTED_REPOS.join(", ")}."
conflicts "--all", "--repos"
named_args :email, number: 1 named_args :email, number: 1
end end
@ -49,9 +45,10 @@ module Homebrew
commits = 0 commits = 0
coauthorships = 0 coauthorships = 0
repos = args[:repos] || SUPPORTED_REPOS all_repos = args[:repos].first == "all"
repos = all_repos ? SUPPORTED_REPOS : args[:repos]
repos.each do |repo| repos.each do |repo|
if !args[:all] && SUPPORTED_REPOS.exclude?(repo) if SUPPORTED_REPOS.exclude?(repo)
return ofail "Unsupported repo: #{repo}. Try one of #{SUPPORTED_REPOS.join(", ")}." return ofail "Unsupported repo: #{repo}. Try one of #{SUPPORTED_REPOS.join(", ")}."
end end
@ -69,7 +66,7 @@ module Homebrew
sentence = "Person #{args.named.first} directly authored #{commits} commits " \ sentence = "Person #{args.named.first} directly authored #{commits} commits " \
"and co-authored #{coauthorships} commits " \ "and co-authored #{coauthorships} commits " \
"to #{args[:all] ? "all Homebrew repos" : repos.join(", ")}" "across #{all_repos ? "all Homebrew repos" : repos.join(", ")}"
sentence += if args[:from] && args[:to] sentence += if args[:from] && args[:to]
" between #{args[:from]} and #{args[:to]}" " between #{args[:from]} and #{args[:to]}"
elsif args[:from] elsif args[:from]