admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

cmd/developer: fix HOMEBREW_UPDATE_TO_TAG handling.

Browse Source 
The handling of `HOMEBREW_UPDATE_TO_TAG` was incorrect as it implied it
also enabled developer mode whereas the opposite was true.
This commit is contained in:
Mike McQuaid 2024-12-03 09:08:50 +00:00
parent 60890774e0
commit 5f82dd1880
No known key found for this signature in database
1 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Library/Homebrew/cmd/developer.rb
View File

@ -24,28 +24,35 @@ module Homebrew
sig { override.void } sig { override.void }
def run def run
env_vars = []
env_vars << "HOMEBREW_DEVELOPER" if Homebrew::EnvConfig.developer?
env_vars << "HOMEBREW_UPDATE_TO_TAG" if Homebrew::EnvConfig.update_to_tag?
env_vars.map! do |var|
"#{Tty.bold}#{var}#{Tty.reset}"
end
case args.named.first case args.named.first
when nil, "state" when nil, "state"
if env_vars.any? if Homebrew::EnvConfig.developer?
verb = (env_vars.count == 1) ? "is" : "are" puts "Developer mode is enabled because #{Tty.bold}HOMEBREW_DEVELOPER#{Tty.reset} is set."
puts "Developer mode is enabled because #{env_vars.to_sentence} #{verb} set."
elsif Homebrew::EnvConfig.devcmdrun? elsif Homebrew::EnvConfig.devcmdrun?
puts "Developer mode is enabled." puts "Developer mode is enabled because a developer command or `brew developer on` was run."
else else
puts "Developer mode is disabled." puts "Developer mode is disabled."
end end
if Homebrew::EnvConfig.developer? || Homebrew::EnvConfig.devcmdrun?
if Homebrew::EnvConfig.update_to_tag?
puts "However, `brew update` will update to the latest stable tag because " \
"#{Tty.bold}HOMEBREW_UPDATE_TO_TAG#{Tty.reset} is set."
else
puts "`brew update` will update to the latest commit on the `master` branch."
end
else
puts "`brew update` will update to the latest stable tag."
end
when "on" when "on"
Homebrew::Settings.write "devcmdrun", true Homebrew::Settings.write "devcmdrun", true
if Homebrew::EnvConfig.update_to_tag?
puts "To fully enable developer mode, you must unset #{Tty.bold}HOMEBREW_UPDATE_TO_TAG#{Tty.reset}."
end
when "off" when "off"
Homebrew::Settings.delete "devcmdrun" Homebrew::Settings.delete "devcmdrun"
puts "To fully disable developer mode, you must unset #{env_vars.to_sentence}." if env_vars.any? if Homebrew::EnvConfig.developer?
puts "To fully disable developer mode, you must unset #{Tty.bold}HOMEBREW_DEVELOPER#{Tty.reset}."
end
else else
raise UsageError, "unknown subcommand: #{args.named.first}" raise UsageError, "unknown subcommand: #{args.named.first}"
end end