admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: fix "version should not decrease" (again).

Browse Source 
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
This commit is contained in:
Mike McQuaid 2016-11-15 09:02:50 +00:00
parent 484e3e0769
commit 5e0b3d24e5
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/dev-cmd/audit.rb
View File

@ -674,8 +674,10 @@ class FormulaAuditor
attributes_for_version = spec_attribute_map[formula.version]
next if attributes_for_version.nil? || attributes_for_version.empty?
if formula.send(attribute) < attributes_for_version.max
problem "#{spec} #{attribute} should not decrease"
old_attribute = formula.send(attribute)
max_attribute = attributes_for_version.max
if max_attribute && old_attribute < max_attribute
problem "#{spec} #{attribute} should not decrease (from #{max_attribute} to #{old_attribute})"
end
end
@ -687,8 +689,11 @@ class FormulaAuditor
version_scheme.first == max_version_scheme
end.keys.max
if max_version && formula.version < max_version
problem "#{spec} version should not decrease"
formula_spec = formula.send(spec)
next if formula_spec.nil?
if max_version && formula_spec.version < max_version
problem "#{spec} version should not decrease (from #{max_version} to #{formula_spec.version})"
end
end