admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

missing_formula: warn when git-log takes very long

Browse Source
This commit is contained in:
Zhiming Wang 2017-03-22 00:28:01 -04:00 committed by Mike McQuaid
parent 08a22d013e
commit 5da857ce83
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Library/Homebrew/missing_formula.rb
View File

@ -125,11 +125,23 @@ module Homebrew
relative_path = path.relative_path_from tap.path relative_path = path.relative_path_from tap.path
tap.path.cd do tap.path.cd do
# We know this may return incomplete results for shallow clones but begin
# we don't want to nag everyone with a shallow clone to unshallow it. timer_pid = fork do
log_command = "git log --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}" # Let the user know what's going on when the search goes on for
hash, short_hash, *commit_message, relative_path = # more than two seconds.
Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp) sleep 2
opoo "Searching through git history. This may take a while..."
end
# We know this may return incomplete results for shallow clones but
# we don't want to nag everyone with a shallow clone to unshallow it.
log_command = "git log --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}"
hash, short_hash, *commit_message, relative_path =
Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp)
ensure
Process.kill "TERM", timer_pid
end
if hash.to_s.empty? || short_hash.to_s.empty? || if hash.to_s.empty? || short_hash.to_s.empty? ||
relative_path.to_s.empty? relative_path.to_s.empty?
return return