admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Replace integration test with unit test

Browse Source
This commit is contained in:
Douglas Eichelberger 2023-08-07 17:36:13 -07:00
parent 2b29c498fa
commit 5d5c22e104
4 changed files with 22 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/formula.rb
View File

@ -2559,7 +2559,7 @@ class Formula
before: T.nilable(T.any(Pathname, Regexp, String)),
after: T.nilable(T.any(Pathname, String, Symbol)),
audit_result: T::Boolean,
block: T.nilable(T.proc.params(s: StringInreplaceExtension).void),
block: T.nilable(T.proc.params(s: StringInreplaceExtension).void),
).void
}
def inreplace(paths, before = nil, after = nil, audit_result = true, &block) # rubocop:disable Style/OptionalBooleanParameter

36
Library/Homebrew/test/dev-cmd/test_spec.rb
View File

@ -17,40 +17,4 @@ describe "brew test" do
.and not_to_output.to_stderr
.and be_a_success
end
describe "using inreplace" do
it "replaces text in file", :integration_test do
install_test_formula "testball", <<~RUBY
test do
(testpath/"file.txt").write "1"
inreplace testpath/"file.txt" do |s|
s.gsub! "1", "2"
end
assert_equal "2", (testpath/"file.txt").read
end
RUBY
expect { brew "test", "--verbose", "testball" }
.to output(/Testing testball/).to_stdout
.and not_to_output.to_stderr
.and be_a_success
end
it "fails when assertion fails", :integration_test do
install_test_formula "testball", <<~RUBY
test do
(testpath/"file.txt").write "1"
inreplace testpath/"file.txt" do |s|
s.gsub! "1", "2"
end
assert_equal "3", (testpath/"file.txt").read
end
RUBY
expect { brew "test", "--verbose", "testball" }
.to output(/Testing testball/).to_stdout
.and output(/Expected: "3"\n Actual: "2"/).to_stderr
.and be_a_failure
end
end
end

20
Library/Homebrew/test/formula_spec.rb
View File

@ -464,6 +464,26 @@ describe Formula do
expect { f.inreplace([]) }.to raise_error(BuildError)
end
specify "replaces text in file" do
file = Tempfile.new("test")
File.binwrite(file, <<~EOS)
ab
bc
cd
EOS
f = formula do
url "https://brew.sh/test-1.0.tbz"
end
f.inreplace(file.path) do |s|
s.gsub!("bc", "yz")
end
expect(File.binread(file)).to eq <<~EOS
ab
yz
cd
EOS
end
end
describe "::installed_with_alias_path" do

2
Library/Homebrew/utils/inreplace.rb
View File

@ -41,7 +41,7 @@ module Utils
before: T.nilable(T.any(Pathname, Regexp, String)),
after: T.nilable(T.any(Pathname, String, Symbol)),
audit_result: T::Boolean,
block: T.nilable(T.proc.params(s: StringInreplaceExtension).void),
block: T.nilable(T.proc.params(s: StringInreplaceExtension).void),
).void
}
def self.inreplace(paths, before = nil, after = nil, audit_result: true, &block)