From 5ce4966f4a3b8de955c5850ad826c0e072ab3f8b Mon Sep 17 00:00:00 2001 From: Issy Long Date: Sun, 19 Mar 2023 19:19:00 +0000 Subject: [PATCH] rubocops/cask: Use `ON_SYSTEM_METHODS` for skipping Co-authored-by: Rylan Polster --- Library/Homebrew/rubocops/cask/no_overrides.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/cask/no_overrides.rb b/Library/Homebrew/rubocops/cask/no_overrides.rb index faa51bfbec..4e9a4edee4 100644 --- a/Library/Homebrew/rubocops/cask/no_overrides.rb +++ b/Library/Homebrew/rubocops/cask/no_overrides.rb @@ -20,7 +20,7 @@ module RuboCop # TODO: We probably only want to disallow `version`, `url`, and `sha256` stanzas being overridden? next unless RuboCop::Cask::Constants::STANZA_ORDER.include?(stanza.stanza_name) # Skip if the stanza we detect is already in an `on_*` block. - next if stanza.parent_node.block_type? && stanza.parent_node.method_name.to_s.start_with?("on_") + next if stanza.parent_node.block_type? && RuboCop::Cask::Constants::ON_SYSTEM_METHODS.include?(stanza.parent_node.method_name) add_offense(stanza.source_range, message: format(MESSAGE, stanza: stanza.stanza_name)) end