admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Improve #to_str and #to_json for Version::NULL.

Browse Source
This commit is contained in:
Markus Reiter 2023-05-11 11:21:19 +02:00
parent fff93a8781
commit 5c9c089b68
No known key found for this signature in database
GPG Key ID: 245293B51702655B
2 changed files with 345 additions and 270 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

593
Library/Homebrew/test/version_spec.rb
View File

File diff suppressed because it is too large Load Diff

22
Library/Homebrew/version.rb
View File

@ -535,7 +535,7 @@ class Version
sig { returns(T::Boolean) } sig { returns(T::Boolean) }
def null? def null?
@version.nil? version.nil?
end end
sig { params(comparator: String, other: Version).returns(T::Boolean) } sig { params(comparator: String, other: Version).returns(T::Boolean) }
@ -703,7 +703,25 @@ class Version
def to_s def to_s
version.to_s version.to_s
end end
alias to_str to_s
sig { returns(String) }
def to_str
raise NoMethodError, "undefined method `to_str' for #{self.class}:NULL" if null?
T.must(version).to_str
end
sig { params(options: Hash).returns(String) }
def to_json(**options)
version.to_json(**options)
end
sig { params(method: T.any(Symbol, String), include_all: T::Boolean).returns(T::Boolean) }
def respond_to?(method, include_all = T.unsafe(nil))
return !null? if ["to_str", :to_str].include?(method)
super
end
sig { returns(String) } sig { returns(String) }
def inspect def inspect