admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #11169 from issyl0/fix-patch-url-autocorrection

Browse Source 
rubocops/patches: Fix quoting of the patch `url` when autocorrecting
This commit is contained in:
Issy Long 2021-04-16 20:10:16 +01:00 committed by GitHub
commit 5c352437d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/patches.rb
View File

@ -69,7 +69,7 @@ module RuboCop
gh_patch_param_pattern = %r{https?://github\.com/.+/.+/(?:commit|pull)/[a-fA-F0-9]*.(?:patch|diff)} gh_patch_param_pattern = %r{https?://github\.com/.+/.+/(?:commit|pull)/[a-fA-F0-9]*.(?:patch|diff)}
if regex_match_group(patch_url_node, gh_patch_param_pattern) && !patch_url.match?(/\?full_index=\w+$/) if regex_match_group(patch_url_node, gh_patch_param_pattern) && !patch_url.match?(/\?full_index=\w+$/)
problem "GitHub patches should use the full_index parameter: #{patch_url}?full_index=1" do |corrector| problem "GitHub patches should use the full_index parameter: #{patch_url}?full_index=1" do |corrector|
corrector.replace(patch_url_node.source_range, "#{patch_url}?full_index=1") corrector.replace(patch_url_node.source_range, "\"#{patch_url}?full_index=1\"")
end end
end end