admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Apply suggestions from code review

Browse Source 
Code review changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Lionell Loh Jian An 2020-06-30 22:11:36 +08:00 committed by GitHub
parent da2a426ec8
commit 5b3530b23d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/test/dev-cmd/audit_spec.rb
View File

@ -111,7 +111,6 @@ module Homebrew
RUBY RUBY
fa.audit_license fa.audit_license
p fa.problems
expect(fa.problems.first).to match "No license specified for package." expect(fa.problems.first).to match "No license specified for package."
end end

4
Library/Homebrew/utils/github.rb
View File

@ -477,8 +477,8 @@ module GitHub
end end
def get_repo_license(user, repo) def get_repo_license(user, repo)
res = GitHub.open_api("#{GitHub::API_URL}/repos/#{user}/#{repo}/license") response = GitHub.open_api("#{GitHub::API_URL}/repos/#{user}/#{repo}/license")
return unless res.key?("license") return unless response.key?("license")
res["license"]["spdx_id"] res["license"]["spdx_id"]
rescue GitHub::HTTPNotFoundError rescue GitHub::HTTPNotFoundError