admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

style: add optional rubocop-rspec support.

Browse Source 
It's really noisy and too pedantic for us to use now but I got it
working locally and used `--fix` to generate #3981 so let's add it as an
option for now.
This commit is contained in:
Mike McQuaid 2018-03-25 13:34:57 +01:00
parent ae2dbdba52
commit 58017511a8
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/cmd/style.rb
View File

@ -11,6 +11,8 @@
#: If `--display-cop-names` is passed, include the RuboCop cop name for each #: If `--display-cop-names` is passed, include the RuboCop cop name for each
#: violation in the output. #: violation in the output.
#: #:
#: If `--rspec` is passed, install and use the RuboCop RSpec gem.
#:
#: Passing `--only-cops=`<cops> will check for violations of only the listed #: Passing `--only-cops=`<cops> will check for violations of only the listed
#: RuboCop <cops>, while `--except-cops=`<cops> will skip checking the listed #: RuboCop <cops>, while `--except-cops=`<cops> will skip checking the listed
#: <cops>. For either option <cops> should be a comma-separated list of cop names. #: <cops>. For either option <cops> should be a comma-separated list of cop names.
@ -83,6 +85,11 @@ module Homebrew
args << "--parallel" args << "--parallel"
end end
if ARGV.include?("--rspec")
Homebrew.install_gem! "rubocop-rspec"
args += %w[--require rubocop-rspec]
end
if options[:except_cops] if options[:except_cops]
options[:except_cops].map! { |cop| RuboCop::Cop::Cop.registry.qualified_cop_name(cop.to_s, "") } options[:except_cops].map! { |cop| RuboCop::Cop::Cop.registry.qualified_cop_name(cop.to_s, "") }
cops_to_exclude = options[:except_cops].select do |cop| cops_to_exclude = options[:except_cops].select do |cop|

2
docs/Manpage.md
View File

@ -436,6 +436,8 @@ With `--verbose` or `-v`, many commands print extra debugging information. Note
If `--display-cop-names` is passed, include the RuboCop cop name for each If `--display-cop-names` is passed, include the RuboCop cop name for each
violation in the output. violation in the output.
If `--rspec` is passed, install and use the RuboCop RSpec gem.
Passing `--only-cops=``cops` will check for violations of only the listed Passing `--only-cops=``cops` will check for violations of only the listed
RuboCop `cops`, while `--except-cops=``cops` will skip checking the listed RuboCop `cops`, while `--except-cops=``cops` will skip checking the listed
`cops`. For either option `cops` should be a comma-separated list of cop names. `cops`. For either option `cops` should be a comma-separated list of cop names.

3
manpages/brew.1
View File

@ -446,6 +446,9 @@ If \fB\-\-fix\fR is passed, automatically fix style violations using RuboCop\'s
If \fB\-\-display\-cop\-names\fR is passed, include the RuboCop cop name for each violation in the output\. If \fB\-\-display\-cop\-names\fR is passed, include the RuboCop cop name for each violation in the output\.
. .
.IP .IP
If \fB\-\-rspec\fR is passed, install and use the RuboCop RSpec gem\.
.
.IP
Passing \fB\-\-only\-cops=\fR\fIcops\fR will check for violations of only the listed RuboCop \fIcops\fR, while \fB\-\-except\-cops=\fR\fIcops\fR will skip checking the listed \fIcops\fR\. For either option \fIcops\fR should be a comma\-separated list of cop names\. Passing \fB\-\-only\-cops=\fR\fIcops\fR will check for violations of only the listed RuboCop \fIcops\fR, while \fB\-\-except\-cops=\fR\fIcops\fR will skip checking the listed \fIcops\fR\. For either option \fIcops\fR should be a comma\-separated list of cop names\.
. .
.IP .IP