From 5793be5b86d06dd5de5dc1a6e4fd9f1c87fdac28 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Sun, 21 Feb 2021 01:02:57 +0000 Subject: [PATCH] test: Change more `context`s to `describe`s for better sentences - We could have added "to" to the `RSpec/ContextWording` list of valid `context` prefixes, but switching these to `describe` is less special. --- Library/Homebrew/test/cask/dsl_spec.rb | 12 ++++++------ Library/Homebrew/test/os/mac/version_spec.rb | 2 +- Library/Homebrew/test/requirement_spec.rb | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Library/Homebrew/test/cask/dsl_spec.rb b/Library/Homebrew/test/cask/dsl_spec.rb index b1bb3902e7..ad93c252c3 100644 --- a/Library/Homebrew/test/cask/dsl_spec.rb +++ b/Library/Homebrew/test/cask/dsl_spec.rb @@ -168,37 +168,37 @@ describe Cask::DSL, :cask do cask.config = config end - context "when it is 'zh'" do + describe "to 'zh'" do let(:languages) { ["zh"] } it { is_expected.to be_the_chinese_version } end - context "when it is 'zh-XX'" do + describe "to 'zh-XX'" do let(:languages) { ["zh-XX"] } it { is_expected.to be_the_chinese_version } end - context "when it is 'en'" do + describe "to 'en'" do let(:languages) { ["en"] } it { is_expected.to be_the_english_version } end - context "when it is 'xx-XX'" do + describe "to 'xx-XX'" do let(:languages) { ["xx-XX"] } it { is_expected.to be_the_english_version } end - context "when it is 'xx-XX,zh,en'" do + describe "to 'xx-XX,zh,en'" do let(:languages) { ["xx-XX", "zh", "en"] } it { is_expected.to be_the_chinese_version } end - context "when it is 'xx-XX,en-US,zh'" do + describe "to 'xx-XX,en-US,zh'" do let(:languages) { ["xx-XX", "en-US", "zh"] } it { is_expected.to be_the_english_version } diff --git a/Library/Homebrew/test/os/mac/version_spec.rb b/Library/Homebrew/test/os/mac/version_spec.rb index 67f38fa54c..c69e0239bc 100644 --- a/Library/Homebrew/test/os/mac/version_spec.rb +++ b/Library/Homebrew/test/os/mac/version_spec.rb @@ -40,7 +40,7 @@ describe OS::Mac::Version do expect(version).to be < Version.create("10.15") end - context "when after Big Sur" do + describe "after Big Sur" do specify "comparison with :big_sur" do expect(big_sur_major).to eq :big_sur expect(big_sur_major).to be <= :big_sur diff --git a/Library/Homebrew/test/requirement_spec.rb b/Library/Homebrew/test/requirement_spec.rb index 09b4246236..4fe5cad5a1 100644 --- a/Library/Homebrew/test/requirement_spec.rb +++ b/Library/Homebrew/test/requirement_spec.rb @@ -148,7 +148,7 @@ describe Requirement do end describe "#build?" do - context "when :build tag is specified" do + context "when the :build tag is specified" do subject { described_class.new([:build]) } it { is_expected.to be_a_build_requirement }