admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Revert install_artifacts if one artifact fails to install.

Browse Source
This commit is contained in:
Markus Reiter 2016-12-04 23:14:35 +01:00
parent e6d9248787
commit 5785f54f4b
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/cask/lib/hbc/installer.rb
View File

@ -132,14 +132,29 @@ module Hbc
end end
def install_artifacts def install_artifacts
already_installed_artifacts = []
options = { command: @command, force: force }
odebug "Installing artifacts" odebug "Installing artifacts"
artifacts = Artifact.for_cask(@cask) artifacts = Artifact.for_cask(@cask)
odebug "#{artifacts.length} artifact/s defined", artifacts odebug "#{artifacts.length} artifact/s defined", artifacts
artifacts.each do |artifact| artifacts.each do |artifact|
odebug "Installing artifact of class #{artifact}" odebug "Installing artifact of class #{artifact}"
options = { command: @command, force: force } already_installed_artifacts.unshift(artifact)
artifact.new(@cask, options).install_phase artifact.new(@cask, options).install_phase
end end
rescue StandardError => e
begin
ofail e.message
already_installed_artifacts.each do |artifact|
odebug "Reverting installation of artifact of class #{artifact}"
artifact.new(@cask, options).uninstall_phase
end
ensure
purge_versioned_files
raise e.class, "An error occured during installation of Cask #{@cask}: #{e.message}"
end
end end
# TODO: move dependencies to a separate class # TODO: move dependencies to a separate class