From 04184ebc02588ca2c8b51c6a4709e2f4934228f2 Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 6 Jun 2017 04:14:55 +0100 Subject: [PATCH 1/5] os/mac: add Xcode 8.3.3 support --- Library/Homebrew/os/mac.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/os/mac.rb b/Library/Homebrew/os/mac.rb index bc384da308..4f663d7f8f 100644 --- a/Library/Homebrew/os/mac.rb +++ b/Library/Homebrew/os/mac.rb @@ -207,6 +207,7 @@ module OS "8.3" => { clang: "8.1", clang_build: 802 }, "8.3.1" => { clang: "8.1", clang_build: 802 }, "8.3.2" => { clang: "8.1", clang_build: 802 }, + "8.3.3" => { clang: "8.1", clang_build: 802 }, }.freeze def compilers_standard? From a88350425bbee7a610143911badaca933baad05e Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 6 Jun 2017 04:15:36 +0100 Subject: [PATCH 2/5] os/mac/xcode: expect Xcode 8.3.3 --- Library/Homebrew/os/mac/xcode.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/os/mac/xcode.rb b/Library/Homebrew/os/mac/xcode.rb index 9ed95d3f2d..25c35bfa97 100644 --- a/Library/Homebrew/os/mac/xcode.rb +++ b/Library/Homebrew/os/mac/xcode.rb @@ -17,12 +17,12 @@ module OS when "10.9" then "6.2" when "10.10" then "7.2.1" when "10.11" then "8.2.1" - when "10.12" then "8.3.2" + when "10.12" then "8.3.3" else raise "macOS '#{MacOS.version}' is invalid" unless OS::Mac.prerelease? # Default to newest known version of Xcode for unreleased macOS versions. - "8.3.2" + "8.3.3" end end From f545836dd8848fe06f3b113b25f06a6c4e38460a Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 6 Jun 2017 04:16:28 +0100 Subject: [PATCH 3/5] docs/Xcode: document Xcode 8.3.3 --- docs/Xcode.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/Xcode.md b/docs/Xcode.md index 7c2cca5c8f..21ad66f95d 100644 --- a/docs/Xcode.md +++ b/docs/Xcode.md @@ -12,7 +12,7 @@ Tools available for your platform: | 10.9 | 6.2 | 6.2 | | 10.10 | 7.2.1 | 7.2 | | 10.11 | 8.2.1 | 8.2 | -| 10.12 | 8.3.2 | 8.3 | +| 10.12 | 8.3.3 | 8.3 | ## Compiler version database @@ -72,6 +72,7 @@ Tools available for your platform: | 8.3 | — | — | — | — | 8.1 (802.0.38) | — | | 8.3.1 | — | — | — | — | 8.1 (802.0.41) | — | | 8.3.2 | — | — | — | — | 8.1 (802.0.42) | — | +| 8.3.3 | — | — | — | — | 8.1 (802.0.42) | — | ## References to Xcode and compiler versions in code When a new Xcode release is made, the following things need to be From a0ae0346547266a6c55bc470fb51840da9008fbc Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 6 Jun 2017 04:29:18 +0100 Subject: [PATCH 4/5] os/mac: add Xcode 9.0 Beta recognition --- Library/Homebrew/os/mac.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/os/mac.rb b/Library/Homebrew/os/mac.rb index 4f663d7f8f..5074665fca 100644 --- a/Library/Homebrew/os/mac.rb +++ b/Library/Homebrew/os/mac.rb @@ -208,6 +208,7 @@ module OS "8.3.1" => { clang: "8.1", clang_build: 802 }, "8.3.2" => { clang: "8.1", clang_build: 802 }, "8.3.3" => { clang: "8.1", clang_build: 802 }, + "9.0" => { clang: "9.0", clang_build: 900 }, }.freeze def compilers_standard? From cc86d4184d79f6c129b885244c89ea0a9f5fd35b Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 6 Jun 2017 04:33:55 +0100 Subject: [PATCH 5/5] os/mac/xcode: recognise Xcode 9.0 --- Library/Homebrew/os/mac/xcode.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/os/mac/xcode.rb b/Library/Homebrew/os/mac/xcode.rb index 25c35bfa97..20ce6b74fc 100644 --- a/Library/Homebrew/os/mac/xcode.rb +++ b/Library/Homebrew/os/mac/xcode.rb @@ -18,16 +18,18 @@ module OS when "10.10" then "7.2.1" when "10.11" then "8.2.1" when "10.12" then "8.3.3" + when "10.13" then "9.0" else raise "macOS '#{MacOS.version}' is invalid" unless OS::Mac.prerelease? # Default to newest known version of Xcode for unreleased macOS versions. - "8.3.3" + "9.0" end end def minimum_version case MacOS.version + when "10.13" then "9.0" when "10.12" then "8.0" else "2.0" end @@ -152,7 +154,8 @@ module OS when 73 then "7.3" when 80 then "8.0" when 81 then "8.3" - else "8.3" + when 90 then "9.0" + else "9.0" end end