From 25e7eaee1f181c78e0ee09b0b328879d674af389 Mon Sep 17 00:00:00 2001 From: Zach Auten Date: Fri, 21 Jun 2019 00:09:08 -0400 Subject: [PATCH] brew install will suggest brew cask install If the user tries to install a cask using brew install then brew will suggest the user tries 'brew cask install' closes #6245 --- Library/Homebrew/extend/os/mac/missing_formula.rb | 6 +++++- Library/Homebrew/test/missing_formula_spec.rb | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/extend/os/mac/missing_formula.rb b/Library/Homebrew/extend/os/mac/missing_formula.rb index 81f71ac004..58a7906b36 100644 --- a/Library/Homebrew/extend/os/mac/missing_formula.rb +++ b/Library/Homebrew/extend/os/mac/missing_formula.rb @@ -19,7 +19,11 @@ module Homebrew cask = Cask::CaskLoader.load(name) reason = +"Found a cask named \"#{name}\" instead.\n" - reason << Cask::Cmd::Info.get_info(cask) if show_info + if show_info + reason << Cask::Cmd::Info.get_info(cask) + else + reason << "Did you mean to type \"brew cask install #{name}\"?\n" + end reason.freeze rescue Cask::CaskUnavailableError nil diff --git a/Library/Homebrew/test/missing_formula_spec.rb b/Library/Homebrew/test/missing_formula_spec.rb index 30c21b09ae..30464c7391 100644 --- a/Library/Homebrew/test/missing_formula_spec.rb +++ b/Library/Homebrew/test/missing_formula_spec.rb @@ -100,6 +100,7 @@ describe Homebrew::MissingFormula do let(:show_info) { false } it { is_expected.to match(/Found a cask named "local-caffeine" instead./) } + it { is_expected.to match(/Did you mean to type "brew cask install local-caffeine"?/) } end context "with a formula name that is a cask and show_info: true" do