From 570a6607588e5aa2c5dca29d5c2e1328e906b6c3 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Thu, 24 Dec 2020 13:19:02 +0000 Subject: [PATCH] cli/parser: Only prefix short options with one dash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - This avoids error messages like: ``` ➜ brew list -l Error: Invalid usage: `--l` cannot be passed without `--formula`. ``` --- Library/Homebrew/cli/parser.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cli/parser.rb b/Library/Homebrew/cli/parser.rb index 907b4cd17b..5937d66a1f 100644 --- a/Library/Homebrew/cli/parser.rb +++ b/Library/Homebrew/cli/parser.rb @@ -533,8 +533,8 @@ module Homebrew class OptionConstraintError < UsageError def initialize(arg1, arg2, missing: false) - arg1 = "--#{arg1.tr("_", "-")}" - arg2 = "--#{arg2.tr("_", "-")}" + arg1 = arg1.length > 1 ? "--#{arg1.tr("_", "-")}" : "-#{arg1.tr("_", "-")}" + arg2 = arg2.length > 1 ? "--#{arg2.tr("_", "-")}" : "-#{arg2.tr("_", "-")}" message = if missing "`#{arg2}` cannot be passed without `#{arg1}`."