admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

CurlDownloadStrategy: initialize attributes in initializer

Browse Source 
The downloader is instantiated on-demand, so we no longer need the lazy
initialization here.
This commit is contained in:
Jack Nagel 2014-12-05 22:11:23 -05:00
parent d157301cdc
commit 566d6b3a46
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/download_strategy.rb
View File

@ -73,16 +73,13 @@ class VCSDownloadStrategy < AbstractDownloadStrategy
end end
class CurlDownloadStrategy < AbstractDownloadStrategy class CurlDownloadStrategy < AbstractDownloadStrategy
def mirrors attr_reader :mirrors, :tarball_path, :temporary_path
@mirrors ||= resource.mirrors.dup
end
def tarball_path def initialize(name, resource)
@tarball_path ||= Pathname.new("#{HOMEBREW_CACHE}/#{name}-#{resource.version}#{ext}") super
end @mirrors = resource.mirrors.dup
@tarball_path = HOMEBREW_CACHE.join("#{name}-#{resource.version}#{ext}")
def temporary_path @temporary_path = Pathname.new("#{tarball_path}.incomplete")
@temporary_path ||= Pathname.new("#{tarball_path}.incomplete")
end end
def cached_location def cached_location