Apply suggestions from code review
This commit is contained in:
parent
56724da0b7
commit
5657e109af
@ -44,17 +44,7 @@ module Homebrew
|
|||||||
titleized_repo = tap.repo.dup
|
titleized_repo = tap.repo.dup
|
||||||
titleized_user[0] = titleized_user[0].upcase
|
titleized_user[0] = titleized_user[0].upcase
|
||||||
titleized_repo[0] = titleized_repo[0].upcase
|
titleized_repo[0] = titleized_repo[0].upcase
|
||||||
|
root_url = GitHubPackages.root_url(tap.user, "homebrew-#{tap.repo}") if args.github_packages?
|
||||||
pr_pull_env = {}
|
|
||||||
pr_pull_env["HOMEBREW_GITHUB_API_TOKEN"] = "${{ github.token }}"
|
|
||||||
pr_pull_env["PULL_REQUEST"] = "${{ github.event.pull_request.number }}"
|
|
||||||
|
|
||||||
if args.github_packages?
|
|
||||||
pr_pull_env["HOMEBREW_GITHUB_PACKAGES_USER"] = "${{ github.actor }}"
|
|
||||||
pr_pull_env["HOMEBREW_GITHUB_PACKAGES_TOKEN"] = "${{ github.token }}"
|
|
||||||
|
|
||||||
root_url = GitHubPackages.root_url(tap.user, "homebrew-#{tap.repo}")
|
|
||||||
end
|
|
||||||
|
|
||||||
(tap.path/"Formula").mkpath
|
(tap.path/"Formula").mkpath
|
||||||
|
|
||||||
@ -139,7 +129,10 @@ module Homebrew
|
|||||||
|
|
||||||
- name: Pull bottles
|
- name: Pull bottles
|
||||||
env:
|
env:
|
||||||
#{pr_pull_env.map { |k, v| "#{k}: #{v}" }.join "\n#{" " * 10}"}
|
HOMEBREW_GITHUB_API_TOKEN: ${{ github.token }}
|
||||||
|
HOMEBREW_GITHUB_PACKAGES_TOKEN: ${{ github.token }}
|
||||||
|
HOMEBREW_GITHUB_PACKAGES_USER: ${{ github.actor }}
|
||||||
|
PULL_REQUEST: ${{ github.event.pull_request.number }}
|
||||||
run: brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
|
run: brew pr-pull --debug --tap=$GITHUB_REPOSITORY $PULL_REQUEST
|
||||||
|
|
||||||
- name: Push commits
|
- name: Push commits
|
||||||
|
Loading…
x
Reference in New Issue
Block a user