From 564a207badad93788558554336856a14bb9831ab Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Mon, 19 Jul 2021 10:06:38 -0400 Subject: [PATCH] Add `HOMEBREW_NO_DEV_CMD_MESSAGE` --- Library/Homebrew/brew.rb | 2 +- Library/Homebrew/brew.sh | 2 +- Library/Homebrew/dev-cmd/tests.rb | 2 +- Library/Homebrew/env_config.rb | 4 ++++ docs/Manpage.md | 3 +++ manpages/brew.1 | 6 ++++++ 6 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/brew.rb b/Library/Homebrew/brew.rb index 3936b77f2f..8513c93ebd 100644 --- a/Library/Homebrew/brew.rb +++ b/Library/Homebrew/brew.rb @@ -93,7 +93,7 @@ begin internal_cmd ||= begin internal_dev_cmd = Commands.valid_internal_dev_cmd?(cmd) if internal_dev_cmd && !Homebrew::EnvConfig.developer? - if ENV["HOMEBREW_DEV_CMD_RUN"].blank? && ENV["HOMEBREW_TEST"].blank? + if ENV["HOMEBREW_DEV_CMD_RUN"].blank? && !Homebrew::EnvConfig.no_dev_cmd_message? opoo <<~MESSAGE #{Tty.bold}#{cmd}#{Tty.reset} is a developer command, so Homebrew's developer mode has been automatically turned on. diff --git a/Library/Homebrew/brew.sh b/Library/Homebrew/brew.sh index b454a3f96b..cb2d3d6fe4 100644 --- a/Library/Homebrew/brew.sh +++ b/Library/Homebrew/brew.sh @@ -645,7 +645,7 @@ elif [[ -f "${HOMEBREW_LIBRARY}/Homebrew/dev-cmd/${HOMEBREW_COMMAND}.sh" ]] then if [[ -z "${HOMEBREW_DEVELOPER}" ]] then - if [[ -z "${HOMEBREW_DEV_CMD_RUN}" ]] && [[ -z "${HOMEBREW_TEST}" ]] + if [[ -z "${HOMEBREW_DEV_CMD_RUN}" ]] && [[ -z "${HOMEBREW_NO_DEV_CMD_MESSAGE}" ]] then message="$(bold "${HOMEBREW_COMMAND}") is a developer command, so Homebrew's developer mode has been automatically turned on. diff --git a/Library/Homebrew/dev-cmd/tests.rb b/Library/Homebrew/dev-cmd/tests.rb index df3d014350..95f97b6a8f 100644 --- a/Library/Homebrew/dev-cmd/tests.rb +++ b/Library/Homebrew/dev-cmd/tests.rb @@ -87,7 +87,7 @@ module Homebrew ENV.delete(env) end - ENV["HOMEBREW_TEST"] = "1" + ENV["HOMEBREW_NO_DEV_CMD_MESSAGE"] = "1" ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1" ENV["HOMEBREW_NO_COMPAT"] = "1" if args.no_compat? ENV["HOMEBREW_TEST_GENERIC_OS"] = "1" if args.generic? diff --git a/Library/Homebrew/env_config.rb b/Library/Homebrew/env_config.rb index 1a0aae3a4d..91a133899c 100644 --- a/Library/Homebrew/env_config.rb +++ b/Library/Homebrew/env_config.rb @@ -235,6 +235,10 @@ module Homebrew description: "If set, disable all use of legacy compatibility code.", boolean: true, }, + HOMEBREW_NO_DEV_CMD_MESSAGE: { + description: "If set, do not display a warning message when running a developer command for the first time.", + boolean: true, + }, HOMEBREW_NO_EMOJI: { description: "If set, do not print `HOMEBREW_INSTALL_BADGE` on a successful build." \ "\n\n *Note:* Will only try to print emoji on OS X Lion or newer.", diff --git a/docs/Manpage.md b/docs/Manpage.md index 8c87e39086..33e2d586f9 100644 --- a/docs/Manpage.md +++ b/docs/Manpage.md @@ -2027,6 +2027,9 @@ example, run `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just - `HOMEBREW_NO_COMPAT`
If set, disable all use of legacy compatibility code. +- `HOMEBREW_NO_DEV_CMD_MESSAGE` +
If set, do not display a warning message when running a developer command for the first time. + - `HOMEBREW_NO_EMOJI`
If set, do not print `HOMEBREW_INSTALL_BADGE` on a successful build. diff --git a/manpages/brew.1 b/manpages/brew.1 index 3aba312e29..082fdbeafe 100644 --- a/manpages/brew.1 +++ b/manpages/brew.1 @@ -2923,6 +2923,12 @@ If set, do not print text with colour added\. If set, disable all use of legacy compatibility code\. . .TP +\fBHOMEBREW_NO_DEV_CMD_MESSAGE\fR +. +.br +If set, do not display a warning message when running a developer command for the first time\. +. +.TP \fBHOMEBREW_NO_EMOJI\fR . .br