admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

more stringent auditing of checksums

Browse Source 
Closes Homebrew/homebrew#10213.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Trevor Wennblom 2012-02-15 21:44:14 -06:00 committed by Jack Nagel
parent 1d9ada295a
commit 555b16962f
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Library/Homebrew/cmd/audit.rb
View File

@ -75,18 +75,31 @@ def audit_formula_text name, text
end end
# Empty checksums # Empty checksums
if text =~ /md5\s+(\'\'|\"\")/ if text =~ /md5\s+(''|"")/
problems << " * md5 is empty" problems << " * md5 is empty"
end end
if text =~ /sha1\s+(\'\'|\"\")/ if text =~ /sha1\s+(''|"")/
problems << " * sha1 is empty" problems << " * sha1 is empty"
end end
if text =~ /sha256\s+(\'\'|\"\")/ if text =~ /sha256\s+(''|"")/
problems << " * sha256 is empty" problems << " * sha256 is empty"
end end
# Checksum sanity check
if text =~ /md5\s+['"](.+)['"]/ and $1 != '#{md5}' and $1 !~ /[a-f0-9]{32}/
problems << " * md5 contains invalid or incorrect number of characters"
end
if text =~ /sha1\s+['"](.+)['"]/ and $1 != '#{sha1}' and $1 !~ /[a-f0-9]{40}/
problems << " * sha1 contains invalid or incorrect number of characters"
end
if text =~ /sha256\s+['"](.+)['"]/ and $1 != '#{sha256}' and $1 !~ /[a-f0-9]{64}/
problems << " * sha256 contains invalid or incorrect number of characters"
end
# Commented-out depends_on # Commented-out depends_on
if text =~ /#\s*depends_on\s+(.+)\s*$/ if text =~ /#\s*depends_on\s+(.+)\s*$/
problems << " * Commented-out dep #{$1}." problems << " * Commented-out dep #{$1}."