admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

utils/github: Switch check_fork_exists to fork_exists?

Browse Source 
- It's Ruby style convention that methods that return only booleans end with a
  question mark.
This commit is contained in:
Issy Long 2023-02-26 00:15:25 +00:00
parent a13556a1a6
commit 550599d03b
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/utils/github.rb
View File

@ -147,7 +147,7 @@ module GitHub
API.open_rest(url, data: data, scopes: scopes) API.open_rest(url, data: data, scopes: scopes)
end end
def check_fork_exists(repo, org: nil) def fork_exists?(repo, org: nil)
_, reponame = repo.split("/") _, reponame = repo.split("/")
username = org || API.open_rest(url_to("user")) { |json| json["login"] } username = org || API.open_rest(url_to("user")) { |json| json["login"] }
@ -555,7 +555,7 @@ module GitHub
def forked_repo_info!(tap_remote_repo, org: nil) def forked_repo_info!(tap_remote_repo, org: nil)
response = create_fork(tap_remote_repo, org: org) response = create_fork(tap_remote_repo, org: org)
# GitHub API responds immediately but fork takes a few seconds to be ready. # GitHub API responds immediately but fork takes a few seconds to be ready.
sleep 1 until check_fork_exists(tap_remote_repo, org: org) sleep 1 until fork_exists?(tap_remote_repo, org: org)
remote_url = if system("git", "config", "--local", "--get-regexp", "remote..*.url", "git@github.com:.*") remote_url = if system("git", "config", "--local", "--get-regexp", "remote..*.url", "git@github.com:.*")
response.fetch("ssh_url") response.fetch("ssh_url")
else else