From 5442a7e34f265dd625a4fe63fb5aeb8b9a9e7a77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=81=AA=E3=81=A4=E3=81=8D?= Date: Fri, 9 Aug 2024 10:59:06 -0700 Subject: [PATCH] Honor homebrew curlrc config for analytics --- Library/Homebrew/utils/analytics.rb | 3 ++- Library/Homebrew/utils/curl.rb | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/utils/analytics.rb b/Library/Homebrew/utils/analytics.rb index 1172462d08..0bc02f738f 100644 --- a/Library/Homebrew/utils/analytics.rb +++ b/Library/Homebrew/utils/analytics.rb @@ -54,12 +54,13 @@ module Utils require "utils/curl" curl = Utils::Curl.curl_executable + args = Utils::Curl.curl_args(*args, "--silent", "--output", "/dev/null", show_error: false) if ENV["HOMEBREW_ANALYTICS_DEBUG"] puts "#{curl} #{args.join(" ")} \"#{url}\"" puts Utils.popen_read(curl, *args, url) else pid = fork do - exec curl, *args, "--silent", "--output", "/dev/null", url + exec curl, *args, url end Process.detach T.must(pid) end diff --git a/Library/Homebrew/utils/curl.rb b/Library/Homebrew/utils/curl.rb index a5fe7bab5f..fea66022a3 100644 --- a/Library/Homebrew/utils/curl.rb +++ b/Library/Homebrew/utils/curl.rb @@ -65,7 +65,7 @@ module Utils show_error: T.nilable(T::Boolean), user_agent: T.any(String, Symbol, NilClass), referer: T.nilable(String), - ).returns(T::Array[T.untyped]) + ).returns(T::Array[String]) } def curl_args( *extra_args, @@ -129,7 +129,7 @@ module Utils args << "--referer" << referer if referer.present? - args + extra_args + (args + extra_args).map(&:to_s) end def curl_with_workarounds(