admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Avoid calling to_s on the same Pathname multiple times

Browse Source
This commit is contained in:
Jack Nagel 2013-04-20 13:48:49 -05:00
parent 1e2cb0fd65
commit 51bfd4fc1e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/extend/pathname.rb
View File

@ -122,17 +122,17 @@ class Pathname
# extended to support common double extensions # extended to support common double extensions
alias extname_old extname alias extname_old extname
def extname def extname(path=to_s)
BOTTLE_EXTNAME_RX.match to_s BOTTLE_EXTNAME_RX.match(path)
return $1 if $1 return $1 if $1
/(\.(tar|cpio)\.(gz|bz2|xz|Z))$/.match to_s /(\.(tar|cpio)\.(gz|bz2|xz|Z))$/.match(path)
return $1 if $1 return $1 if $1
return File.extname(to_s) return File.extname(path)
end end
# for filetypes we support, basename without extension # for filetypes we support, basename without extension
def stem def stem
return File.basename(to_s, extname) File.basename((path = to_s), extname(path))
end end
# I don't trust the children.length == 0 check particularly, not to mention # I don't trust the children.length == 0 check particularly, not to mention