admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Fix some false-positive build-time dep audits

Browse Source
This commit is contained in:
Jack Nagel 2013-07-16 15:49:11 -05:00
parent 36051b6a71
commit 51023ef15b
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/cmd/audit.rb
View File

@ -148,13 +148,11 @@ class FormulaAuditor
case dep.name case dep.name
when *BUILD_TIME_DEPS when *BUILD_TIME_DEPS
# TODO: this should really be only dep.build? but maybe some formula next if dep.build?
# depends on the current behavior to be audit-clean? next if dep.name == 'autoconf' && f.name =~ /automake/
next if dep.tags.any? next if dep.name == 'libtool' && %w{imagemagick libgphoto2 libp11}.any? { |n| f.name == n }
next if f.name =~ /automake/ && dep.name == 'autoconf' next if dep.name =~ /autoconf|pkg-config/ && f.name == 'ruby-build'
# This is actually a libltdl dep that gets converted to a non-build time
# libtool dep, but I don't of a good way to encode this in the dep object
next if f.name == 'imagemagick' && dep.name == 'libtool'
problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"} problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
when "git", "ruby", "emacs", "mercurial" when "git", "ruby", "emacs", "mercurial"
problem <<-EOS.undent problem <<-EOS.undent