From 50c967060513baaa7eaa7e4ea1fd2bb667402745 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sat, 10 Nov 2018 12:04:26 +0000 Subject: [PATCH] formula_installer: don't automatically upgrade from another tap. Rather than automatically upgrading a formula from one tap to a formula from another when specified as a dependency require a manual intervention to be clear that's the user's intention. --- Library/Homebrew/formula_installer.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index c49bf2008a..ec7b316d1f 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -568,6 +568,14 @@ class FormulaInstaller installed_keg.rename(tmp_keg) end + tab_tap = tab.source["tap"] + if df.tap.to_s != tab_tap + odie <<~EOS + #{df} is already installed from #{tab_tap}! + Please `brew uninstall #{df}` first." + EOS + end + fi = FormulaInstaller.new(df) fi.options |= tab.used_options fi.options |= Tab.remap_deprecated_options(df.deprecated_options, dep.options)