admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

add audit for Formula.factory

Browse Source
This commit is contained in:
Adam Vandenberg 2014-02-24 20:23:21 -08:00
parent 27365a568d
commit 50b94ada1b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/cmd/audit.rb
View File

@ -180,7 +180,7 @@ class FormulaAuditor
def audit_conflicts def audit_conflicts
f.conflicts.each do |c| f.conflicts.each do |c|
begin begin
Formula.factory(c.name) Formulary.factory(c.name)
rescue FormulaUnavailableError rescue FormulaUnavailableError
problem "Can't find conflicting formula #{c.name.inspect}." problem "Can't find conflicting formula #{c.name.inspect}."
end end
@ -299,6 +299,10 @@ class FormulaAuditor
if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/ if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/
problem "xcodebuild should be passed an explicit \"SYMROOT\"" problem "xcodebuild should be passed an explicit \"SYMROOT\""
end end
if text =~ /Formula\.factory\(/
problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\""
end
end end
def audit_line(line) def audit_line(line)