admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: allow env :std in custom taps.

Browse Source 
This is a nicer experience than writing `Requirement`s by hand.
This commit is contained in:
Mike McQuaid 2018-01-09 15:26:54 +00:00
parent 9ed1ed3c05
commit 50a84f2535
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/dev-cmd/audit.rb
View File

@ -304,7 +304,7 @@ class FormulaAuditor
def audit_formula_name def audit_formula_name
return unless @strict return unless @strict
# skip for non-official taps # skip for non-official taps
return if formula.tap.nil? || !formula.tap.official? return unless formula.tap&.official?
name = formula.name name = formula.name
@ -718,7 +718,13 @@ class FormulaAuditor
return unless @strict return unless @strict
problem "`#{Regexp.last_match(1)}` in formulae is deprecated" if line =~ /(env :(std|userpaths))/ if formula.tap&.official? && line.include?("env :std")
problem "`env :std` in official tap formulae is deprecated"
end
if line.include?("env :userpaths")
problem "`env :userpaths` in formulae is deprecated"
end
if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/ if line =~ /system ((["'])[^"' ]*(?:\s[^"' ]*)+\2)/
bad_system = Regexp.last_match(1) bad_system = Regexp.last_match(1)