admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Fix undefined variable ruby_version

Browse Source
This commit is contained in:
constXife 2017-06-06 13:45:09 +07:00
parent 51aa2e3f4d
commit 4f5643a676
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/extend/os/mac/diagnostic.rb
View File

@ -195,7 +195,8 @@ module Homebrew
end
def check_ruby_version
return if RUBY_VERSION[/\d\.\d/] == "2.0"
ruby_version = "2.0"
return if RUBY_VERSION[/\d\.\d/] == ruby_version
<<-EOS.undent
Ruby version #{RUBY_VERSION} is unsupported on #{MacOS.version}. Homebrew

14
Library/Homebrew/test/os/mac/diagnostic_spec.rb
View File

@ -45,4 +45,18 @@ describe Homebrew::Diagnostic::Checks do
expect(subject.check_homebrew_prefix)
.to match("Your Homebrew's prefix is not /usr/local.")
end
specify "#check_ruby_version" do
expected_string = <<-EXPECTED
Ruby version 2.3.3p222 is unsupported on 10.13. Homebrew
is developed and tested on Ruby 2.0, and may not work correctly
on other Rubies. Patches are accepted as long as they don't cause breakage
on supported Rubies.
EXPECTED
allow(MacOS).to receive(:version).and_return(OS::Mac::Version.new("10.13"))
stub_const("RUBY_VERSION", "2.3.3p222")
expect(subject.check_ruby_version)
.to match(expected_string)
end
end