admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18443 from Homebrew/warnings-strict

Browse Source 
warnings: `typed: strict`
This commit is contained in:
Mike McQuaid 2024-09-30 08:50:23 +01:00 committed by GitHub
commit 4f07e2f01b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/test/spec_helper.rb
View File

@ -18,6 +18,7 @@ if ENV["HOMEBREW_TESTS_COVERAGE"]
end end
end end
require_relative "../standalone"
require_relative "../warnings" require_relative "../warnings"
Warnings.ignore :parser_syntax do Warnings.ignore :parser_syntax do

12
Library/Homebrew/warnings.rb
View File

@ -1,19 +1,20 @@
# typed: true # rubocop:todo Sorbet/StrictSigil # typed: strict
# frozen_string_literal: true # frozen_string_literal: true
require "warning" require "warning"
# Helper module for handling warnings. # Helper module for handling warnings.
module Warnings module Warnings
COMMON_WARNINGS = { COMMON_WARNINGS = T.let({
parser_syntax: [ parser_syntax: [
%r{warning: parser/current is loading parser/ruby\d+, which recognizes}, %r{warning: parser/current is loading parser/ruby\d+, which recognizes},
/warning: \d+\.\d+\.\d+-compliant syntax, but you are running \d+\.\d+\.\d+\./, /warning: \d+\.\d+\.\d+-compliant syntax, but you are running \d+\.\d+\.\d+\./,
%r{warning: please see https://github\.com/whitequark/parser#compatibility-with-ruby-mri\.}, %r{warning: please see https://github\.com/whitequark/parser#compatibility-with-ruby-mri\.},
], ],
}.freeze }.freeze, T::Hash[Symbol, T::Array[Regexp]])
def self.ignore(*warnings) sig { params(warnings: T.any(Symbol, Regexp), _block: T.nilable(T.proc.void)).void }
def self.ignore(*warnings, &_block)
warnings.map! do |warning| warnings.map! do |warning|
next warning if !warning.is_a?(Symbol) || !COMMON_WARNINGS.key?(warning) next warning if !warning.is_a?(Symbol) || !COMMON_WARNINGS.key?(warning)
@ -25,8 +26,7 @@ module Warnings
end end
return unless block_given? return unless block_given?
result = yield yield
Warning.clear Warning.clear
result
end end
end end