admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Prefer pathname methods over regexp matching

Browse Source
This commit is contained in:
Jack Nagel 2014-05-21 10:54:24 -05:00
parent c6f1ccc215
commit 4f014836f2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/formula_cellar_checks.rb
View File

@ -40,8 +40,7 @@ module FormulaCellarChecks
def check_jars
return unless f.lib.directory?
jars = f.lib.children.select{|g| g.to_s =~ /\.jar$/}
jars = f.lib.children.select { |g| g.extname == ".jar" }
return if jars.empty?
["JARs were installed to \"#{f.lib}\".",
@ -92,7 +91,8 @@ module FormulaCellarChecks
def check_generic_executables bin
return unless bin.directory?
generics = bin.children.select { |g| g.to_s =~ /\/(run|service)$/}
generic_names = %w[run service]
generics = bin.children.select { |g| generic_names.include? g.basename.to_s }
return if generics.empty?
["Generic binaries were installed to \"#{bin}\".",