Merge pull request #3135 from alyssais/core_tap_output

Always output when tapping core
This commit is contained in:
Mike McQuaid 2017-09-08 16:29:22 +01:00 committed by GitHub
commit 4ef03223e0
2 changed files with 3 additions and 5 deletions

View File

@ -124,7 +124,7 @@ module Homebrew
return if ENV["HOMEBREW_UPDATE_TEST"]
core_tap = CoreTap.instance
return if core_tap.installed?
CoreTap.ensure_installed! quiet: false
CoreTap.ensure_installed!
revision = core_tap.git_head
ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision
ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision

View File

@ -551,11 +551,9 @@ class CoreTap < Tap
@instance ||= new
end
def self.ensure_installed!(options = {})
def self.ensure_installed!
return if instance.installed?
args = ["tap", instance.name]
args << "-q" if options.fetch(:quiet, true)
safe_system HOMEBREW_BREW_FILE, *args
safe_system HOMEBREW_BREW_FILE, "tap", instance.name
end
# @private