From 8399c58d2338ce8341ac411cfae01f946548b359 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Sun, 19 Feb 2023 00:11:42 +0000 Subject: [PATCH 1/2] rubocop: Clean up non-existent files/dirs from excludes --- Library/.rubocop.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 744f52c2ee..64aee5590b 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -20,9 +20,8 @@ AllCops: - "**/*.rbi" Exclude: - "Homebrew/sorbet/rbi/gems/**/*.rbi" - - "Homebrew/sorbet/rbi/hidden-definitions/**/*.rbi" + - "Homebrew/sorbet/rbi/hidden-definitions/*.rbi" - "Homebrew/sorbet/rbi/todo.rbi" - - "Homebrew/sorbet/rbi/upstream.rbi" - "Homebrew/bin/*" - "Homebrew/vendor/**/*" - "Taps/*/*/vendor/**/*" From 364c3462b77f62521732d6145fcfb8ca794d50e4 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Sun, 19 Feb 2023 15:53:56 +0000 Subject: [PATCH 2/2] rubocop: `Naming/PredicateName` allows `is_a?` by default https://github.com/rubocop/rubocop/blob/master/lib/rubocop/cop/naming/predicate_name.rb#L16 --- Library/.rubocop.yml | 1 + Library/Homebrew/.rubocop.yml | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 64aee5590b..8b9a828c09 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -9,6 +9,7 @@ inherit_mode: merge: - Include - Exclude + - AllowedMethods AllCops: TargetRubyVersion: 2.6 diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index 5eb3d467b7..4f0dd87d98 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -50,9 +50,7 @@ Metrics/ModuleLength: - "test/**/*" Naming/PredicateName: - # Can't rename these. AllowedMethods: - - is_a? - is_32_bit? - is_64_bit?