From 2f42dfc68a7c3cfdb2d364fc98dff67fea89e78e Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 21 Feb 2017 18:50:07 +0000 Subject: [PATCH] audit: fix revision should be removed. Regression introduced in #1754 which meant that (due to storing the current formula revision in `attributes_map`) `stable_revisions.empty?` would never be `true`. --- Library/Homebrew/dev-cmd/audit.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 9da5d28b4b..d9c4bcddb3 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -816,10 +816,12 @@ class FormulaAuditor return if formula.revision.zero? if formula.stable - revision_map = attributes_map[:revision][:stable] - stable_revisions = revision_map[formula.stable.version] if revision_map - if !stable_revisions || stable_revisions.empty? - problem "'revision #{formula.revision}' should be removed" + if revision_map = attributes_map[:revision][:stable] + stable_revisions = revision_map[formula.stable.version] + stable_revisions -= [formula.revision] + if stable_revisions.empty? + problem "'revision #{formula.revision}' should be removed" + end end else # head/devel-only formula problem "'revision #{formula.revision}' should be removed"