Merge pull request #6443 from MikeMcQuaid/linux-os-version

os/linux: add, use OS::Linux.os_version

Library/Homebrew/extend/os/linux/system_config.rb

@@ -5,18 +5,6 @@ require "os/linux/glibc"
 
 class SystemConfig
   class << self
-    def host_os_version
-      if which("lsb_release")
-        description = `lsb_release -d`.chomp.sub("Description:\t", "")
-        codename = `lsb_release -c`.chomp.sub("Codename:\t", "")
-        "#{description} (#{codename})"
-      elsif (redhat_release = Pathname.new("/etc/redhat-release")).readable?
-        redhat_release.read.chomp
-      else
-        "N/A"
-      end
-    end
-
     def host_glibc_version
       version = OS::Linux::Glibc.system_version
       return "N/A" if version.null?
@@ -42,7 +30,7 @@ class SystemConfig
     def dump_verbose_config(out = $stdout)
       dump_generic_verbose_config(out)
       out.puts "Kernel: #{`uname -mors`.chomp}"
-      out.puts "OS: #{host_os_version}"
+      out.puts "OS: #{OS::Linux.os_version}"
       out.puts "Host glibc: #{host_glibc_version}"
       out.puts "/usr/bin/gcc: #{host_gcc_version}"
       ["glibc", "gcc", "xorg"].each do |f|

Library/Homebrew/os/linux.rb

@@ -1,6 +1,26 @@
 # frozen_string_literal: true
 
 module OS
+  module Linux
+    module_function
+
+    def os_version
+      if which("lsb_release")
+        description = Utils.popen_read("lsb_release -d")
+                           .chomp
+                           .sub("Description:\t", "")
+        codename = Utils.popen_read("lsb_release -c")
+                        .chomp
+                        .sub("Codename:\t", "")
+        "#{description} (#{codename})"
+      elsif (redhat_release = Pathname.new("/etc/redhat-release")).readable?
+        redhat_release.read.chomp
+      else
+        "Unknown"
+      end
+    end
+  end
+
   # Define OS::Mac on Linux for formula API compatibility.
   module Mac
     module_function