admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check MacPorts patch URLs

Browse Source 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-05-07 17:44:57 -05:00
parent c2fdcf1a34
commit 4d027874b0
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/cmd/audit.rb
View File

@ -120,11 +120,6 @@ def audit_formula_text name, text
problems << " * Use 'ARGV.include?' instead of 'ARGV.flag?'" problems << " * Use 'ARGV.include?' instead of 'ARGV.flag?'"
end end
# MacPorts patches should specify a revision, not trunk
if text =~ %r[macports/trunk]
problems << " * MacPorts patches should specify a revision instead of trunk"
end
# Avoid hard-coding compilers # Avoid hard-coding compilers
if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]] if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]]
problems << " * Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\"" problems << " * Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\""
@ -211,9 +206,13 @@ def audit_formula_patches f
patches = Patches.new(f.patches) patches = Patches.new(f.patches)
patches.each do |p| patches.each do |p|
next unless p.external? next unless p.external?
if p.url =~ %r[raw\.github\.com] case p.url
when %r[raw\.github\.com], %r[gist\.github\.com/raw]
problems << " * Using raw GitHub URLs is not recommended:" problems << " * Using raw GitHub URLs is not recommended:"
problems << " * #{p.url}" problems << " #{p.url}"
when %r[macports/trunk]
problems << " * MacPorts patches should specify a revision instead of trunk:"
problems << " #{p.url}"
end end
end end
return problems return problems