From 4cd2775d4f0a70bbc18ba5de8b94b23a87d7f3e1 Mon Sep 17 00:00:00 2001 From: EricFromCanada Date: Wed, 20 Nov 2019 16:57:19 -0500 Subject: [PATCH] info: use hyphenated category names for formula analytics --- Library/Homebrew/cmd/info.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/cmd/info.rb b/Library/Homebrew/cmd/info.rb index 6d43555563..0aebd6dd22 100644 --- a/Library/Homebrew/cmd/info.rb +++ b/Library/Homebrew/cmd/info.rb @@ -238,7 +238,7 @@ module Homebrew valid_categories = %w[install install-on-request cask-install build-error os-version] if category.present? - unless valid_categories.include?(category.tr("_", "-")) + unless valid_categories.include?(category) raise UsageError, "category must be one of #{valid_categories.join(", ")}" end end @@ -375,7 +375,8 @@ module Homebrew full_analytics = args.analytics? || args.verbose? ohai "Analytics" - json["analytics"].each do |category, value| + json["analytics"].each do |category_, value| + category = category_.tr("_", "-") analytics = [] value.each do |days, results| @@ -384,9 +385,8 @@ module Homebrew if args.days.present? next if args.days&.to_i != days end - if args.category.present? - next if args.category.tr("-", "_") != category + next if args.category != category end analytics_table(category, days, results)