admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: add more checks for conflics_with audit

Browse Source
This commit is contained in:
Alexander Bayandin 2021-06-14 14:14:36 +01:00
parent 736278c020
commit 4c14675021
No known key found for this signature in database
GPG Key ID: 444BD9CA93262701
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/formula_auditor.rb
View File

@ -315,7 +315,14 @@ module Homebrew
def audit_conflicts def audit_conflicts
formula.conflicts.each do |c| formula.conflicts.each do |c|
Formulary.factory(c.name) conflicting_formula = Formulary.factory(c.name)
problem "Formula should not conflict with itself" if formula == conflicting_formula
# Use Formula instead of FormulaConflict to be able correctly handle renamed formulae and aliases
reverse_conflicts = conflicting_formula.conflicts.map { |rc| Formulary.factory(rc.name) }
if reverse_conflicts.exclude? formula
problem "Formula #{conflicting_formula.name} should also have a conflict declared with #{formula.name}"
end
rescue TapFormulaUnavailableError rescue TapFormulaUnavailableError
# Don't complain about missing cross-tap conflicts. # Don't complain about missing cross-tap conflicts.
next next