admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

readall: Bump to Sorbet typed: strict

Browse Source
This commit is contained in:
Issy Long 2024-08-10 15:02:43 +01:00
parent ef9520cd6c
commit 4bfbc6a4ff
No known key found for this signature in database
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/readall.rb
View File

@ -1,4 +1,4 @@
# typed: true # typed: strict
# frozen_string_literal: true # frozen_string_literal: true
require "formula" require "formula"
@ -16,6 +16,7 @@ module Readall
private_class_method :cache private_class_method :cache
sig { params(ruby_files: T::Array[Pathname]).returns(T::Boolean) }
def self.valid_ruby_syntax?(ruby_files) def self.valid_ruby_syntax?(ruby_files)
failed = T.let(false, T::Boolean) failed = T.let(false, T::Boolean)
ruby_files.each do |ruby_file| ruby_files.each do |ruby_file|
@ -25,6 +26,7 @@ module Readall
!failed !failed
end end
sig { params(alias_dir: Pathname, formula_dir: Pathname).returns(T::Boolean) }
def self.valid_aliases?(alias_dir, formula_dir) def self.valid_aliases?(alias_dir, formula_dir)
return true unless alias_dir.directory? return true unless alias_dir.directory?
@ -46,6 +48,7 @@ module Readall
!failed !failed
end end
sig { params(tap: Tap, bottle_tag: T.nilable(Utils::Bottles::Tag)).returns(T::Boolean) }
def self.valid_formulae?(tap, bottle_tag: nil) def self.valid_formulae?(tap, bottle_tag: nil)
cache[:valid_formulae] ||= {} cache[:valid_formulae] ||= {}
@ -55,7 +58,7 @@ module Readall
next if valid == true || valid&.include?(bottle_tag) next if valid == true || valid&.include?(bottle_tag)
formula_name = file.basename(".rb").to_s formula_name = file.basename(".rb").to_s
formula_contents = file.read(encoding: "UTF-8") formula_contents = File.read(file, encoding: "UTF-8")
readall_namespace = "ReadallNamespace" readall_namespace = "ReadallNamespace"
readall_formula_class = Formulary.load_formula(formula_name, file, formula_contents, readall_namespace, readall_formula_class = Formulary.load_formula(formula_name, file, formula_contents, readall_namespace,
@ -79,10 +82,16 @@ module Readall
success success
end end
sig { params(_tap: Tap, os_name: T.nilable(Symbol), arch: T.nilable(Symbol)).returns(T::Boolean) }
def self.valid_casks?(_tap, os_name: nil, arch: nil) def self.valid_casks?(_tap, os_name: nil, arch: nil)
true true
end end
sig {
params(
tap: Tap, aliases: T::Boolean, no_simulate: T::Boolean, os_arch_combinations: T::Array[T::Array[String]],
).returns(T::Boolean)
}
def self.valid_tap?(tap, aliases: false, no_simulate: false, def self.valid_tap?(tap, aliases: false, no_simulate: false,
os_arch_combinations: OnSystem::ALL_OS_ARCH_COMBINATIONS) os_arch_combinations: OnSystem::ALL_OS_ARCH_COMBINATIONS)
success = true success = true
@ -110,6 +119,7 @@ module Readall
success success
end end
sig { params(filename: Pathname).returns(T::Boolean) }
private_class_method def self.syntax_errors_or_warnings?(filename) private_class_method def self.syntax_errors_or_warnings?(filename)
# Retrieve messages about syntax errors/warnings printed to `$stderr`. # Retrieve messages about syntax errors/warnings printed to `$stderr`.
_, err, status = system_command(RUBY_PATH, args: ["-c", "-w", filename], print_stderr: false) _, err, status = system_command(RUBY_PATH, args: ["-c", "-w", filename], print_stderr: false)