From 4bbefc12e36bb3cbe661983f7533110a0f85758e Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 7 Jan 2015 15:21:20 -0500 Subject: [PATCH] Eliminate boolean argument to Version.new --- Library/Homebrew/version.rb | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb index a35c22974d..ca5311c8fd 100644 --- a/Library/Homebrew/version.rb +++ b/Library/Homebrew/version.rb @@ -155,26 +155,30 @@ class Version StringToken::PATTERN ) - def self.detect(url, specs={}) - if specs.has_key?(:tag) - new(specs[:tag][/((?:\d+\.)*\d+)/, 1], true) - else - parse(url) + class FromURL < Version + def detected_from_url? + true end end - def initialize(val, detected=false) + def self.detect(url, specs={}) + if specs.has_key?(:tag) + FromURL.new(specs[:tag][/((?:\d+\.)*\d+)/, 1]) + else + FromURL.parse(url) + end + end + + def initialize(val) if val.respond_to?(:to_str) @version = val.to_str else raise TypeError, "Version value must be a string" end - - @detected_from_url = detected end def detected_from_url? - @detected_from_url + false end def head? @@ -236,7 +240,7 @@ class Version def self.parse spec version = _parse(spec) - new(version, true) unless version.nil? + new(version) unless version.nil? end def self._parse spec