From 4af8bdf111b46a11c86a1b5a75e0698719ad2a1a Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Mon, 20 Mar 2017 18:10:28 +0200 Subject: [PATCH] update-report: migrate all formulae every time. Unmigrated formulae cause hard-to-debug issues and relying on detection on Git alone is faster but not comprehensive. Instead, iterate through renamed, installed formulae every time and migrate them. Closes #1770. --- Library/Homebrew/cmd/update-report.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb index c13d820905..00dbfe758c 100644 --- a/Library/Homebrew/cmd/update-report.rb +++ b/Library/Homebrew/cmd/update-report.rb @@ -499,10 +499,14 @@ class Reporter end def migrate_formula_rename - report[:R].each do |old_full_name, new_full_name| - old_name = old_full_name.split("/").last + Formula.installed.map(&:oldname).compact.each do |old_name| next unless (dir = HOMEBREW_CELLAR/old_name).directory? && !dir.subdirs.empty? + new_name = tap.formula_renames[old_name] + next unless new_name + + new_full_name = "#{tap}/#{new_name}" + begin f = Formulary.factory(new_full_name) rescue Exception => e