From 425cc76da96239c2201aac78f370dac02db4b8b3 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Mon, 17 Aug 2020 20:08:45 +0200 Subject: [PATCH] Refactor and document `PkgVersion`. --- Library/Homebrew/pkg_version.rb | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/Library/Homebrew/pkg_version.rb b/Library/Homebrew/pkg_version.rb index b4b1379653..cd74821087 100644 --- a/Library/Homebrew/pkg_version.rb +++ b/Library/Homebrew/pkg_version.rb @@ -2,24 +2,22 @@ require "version" +# Combination of a version and a revision. +# +# @api private class PkgVersion include Comparable extend Forwardable - RX = /\A(.+?)(?:_(\d+))?\z/.freeze + REGEX = /\A(.+?)(?:_(\d+))?\z/.freeze + private_constant :REGEX attr_reader :version, :revision - delegate [ # rubocop:disable Layout/HashAlignment - :major, - :minor, - :patch, - :major_minor, - :major_minor_patch, - ] => :version + delegate [:major, :minor, :patch, :major_minor, :major_minor_patch] => :version def self.parse(path) - _, version, revision = *path.match(RX) + _, version, revision = *path.match(REGEX) version = Version.create(version) new(version, revision.to_i) end