admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/urls: remove dead link

Browse Source
This commit is contained in:
Eric Knibbe 2024-05-06 22:57:23 -04:00
parent d1d0bfc0ba
commit 4932fb7fd0
No known key found for this signature in database
GPG Key ID: 179D9CDDDB814168
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/rubocops/urls.rb
View File

@ -143,10 +143,7 @@ module RuboCop
end end
if url.match?(%r{^https?://prdownloads\.}) if url.match?(%r{^https?://prdownloads\.})
problem <<~EOS.chomp problem "Don't use prdownloads in SourceForge urls (url is #{url})."
Don't use prdownloads in SourceForge urls (url is #{url}).
See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
EOS
end end
if url.match?(%r{^http://\w+\.dl\.}) if url.match?(%r{^http://\w+\.dl\.})

6
Library/Homebrew/test/rubocops/urls_spec.rb
View File

@ -63,10 +63,8 @@ RSpec.describe RuboCop::Cop::FormulaAudit::Urls do
"col" => 2, "col" => 2,
}, { }, {
"url" => "http://prdownloads.sourceforge.net/foo/foo-1.tar.gz", "url" => "http://prdownloads.sourceforge.net/foo/foo-1.tar.gz",
"msg" => <<~EOS.chomp, "msg" => "Don't use prdownloads in SourceForge urls " \
Don't use prdownloads in SourceForge urls (url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz). "(url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz).",
See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
EOS
"col" => 2, "col" => 2,
}, { }, {
"url" => "http://foo.dl.sourceforge.net/sourceforge/foozip/foozip_1.0.tar.bz2", "url" => "http://foo.dl.sourceforge.net/sourceforge/foozip/foozip_1.0.tar.bz2",