admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #6397 from amyspark/upgrade-bfs

Browse Source 
breadth-first search for dependents upgrade
This commit is contained in:
Mike McQuaid 2019-08-23 08:25:55 +01:00 committed by GitHub
commit 4822241d6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
Library/Homebrew/cmd/upgrade.rb
View File

@ -213,37 +213,43 @@ module Homebrew
formulae_to_upgrade = Set.new
formulae_pinned = Set.new
formulae.each do |formula|
formulae_to_check = formulae
checked_formulae = Set.new
until formulae_to_check.empty?
descendants = Set.new
dependents = kegs.select do |keg|
keg.runtime_dependencies
.any? { |d| d["full_name"] == formula.full_name }
end
formulae_to_check.each do |formula|
next if checked_formulae.include?(formula)
next if dependents.empty?
dependent_formulae = dependents.map(&:to_formula)
dependent_formulae.each do |f|
next if formulae_to_upgrade.include?(f)
next if formulae_pinned.include?(f)
if f.outdated?(fetch_head: args.fetch_HEAD?)
if f.pinned?
formulae_pinned << f
else
formulae_to_upgrade << f
end
dependents = kegs.select do |keg|
keg.runtime_dependencies
.any? { |d| d["full_name"] == formula.full_name }
end
descendants << f
next if dependents.empty?
dependent_formulae = dependents.map(&:to_formula)
dependent_formulae.each do |f|
next if formulae_to_upgrade.include?(f)
next if formulae_pinned.include?(f)
if f.outdated?(fetch_head: args.fetch_HEAD?)
if f.pinned?
formulae_pinned << f
else
formulae_to_upgrade << f
end
end
descendants << f
end
checked_formulae << formula
end
upgradable_descendants, pinned_descendants = upgradable_dependents(kegs, descendants)
formulae_to_upgrade.merge upgradable_descendants
formulae_pinned.merge pinned_descendants
formulae_to_check = descendants
end
[formulae_to_upgrade, formulae_pinned]