admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

update-report: optimise update_report_only_installed code.

Browse Source
This commit is contained in:
Mike McQuaid 2022-02-28 09:58:20 +00:00
parent d48a9337e4
commit 47f8636e7d
No known key found for this signature in database
GPG Key ID: 3338A31AFDB1D829
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/cmd/update-report.rb
View File

@ -413,7 +413,7 @@ class Reporter
renamed_formulae << [old_full_name, new_full_name] renamed_formulae << [old_full_name, new_full_name]
end end
unless renamed_formulae.empty? if renamed_formulae.present?
@report[:A] -= renamed_formulae.map(&:last) @report[:A] -= renamed_formulae.map(&:last)
@report[:D] -= renamed_formulae.map(&:first) @report[:D] -= renamed_formulae.map(&:first)
@report[:R] = renamed_formulae.to_a @report[:R] = renamed_formulae.to_a
@ -593,20 +593,21 @@ class ReporterHub
private private
def dump_formula_report(key, title) def dump_formula_report(key, title)
# TODO: 3.4.0: odisabled the old functionality and make this default
only_installed = Homebrew::EnvConfig.update_report_only_installed? only_installed = Homebrew::EnvConfig.update_report_only_installed?
formulae = select_formula(key).sort.map do |name, new_name| formulae = select_formula(key).sort.map do |name, new_name|
# Format list items of renamed formulae # Format list items of renamed formulae
case key case key
when :R when :R
name = pretty_installed(name) if installed?(name) unless only_installed
new_name = pretty_installed(new_name) if installed?(new_name) name = pretty_installed(name) if installed?(name)
"#{name} -> #{new_name}" unless only_installed new_name = pretty_installed(new_name) if installed?(new_name)
"#{name} -> #{new_name}"
end
when :A when :A
name if !installed?(name) && !only_installed name if !only_installed && !installed?(name)
when :AC when :AC
name.split("/").last if !cask_installed?(name) && !only_installed name.split("/").last if !only_installed && !cask_installed?(name)
when :MC, :DC when :MC, :DC
name = name.split("/").last name = name.split("/").last
if cask_installed?(name) if cask_installed?(name)