From 47bfad64b05346fc6ba2e0c57cc6c1e2318c109c Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 27 Oct 2017 09:34:38 +0100 Subject: [PATCH] rubocop.yml: re-add Homebrew metrics maximums. --- Library/Homebrew/.rubocop.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index 0e1fb2d041..3548677389 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -25,6 +25,10 @@ Lint/NestedMethodDefinition: Lint/ParenthesesAsGroupedExpression: Enabled: true +# TODO: try to bring down all metrics maximums +Metrics/AbcSize: + Max: 250 + Metrics/BlockLength: Max: 1250 @@ -34,12 +38,24 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 1226 +Metrics/CyclomaticComplexity: + Max: 75 + Metrics/LineLength: + # 124 is the goal as GitHub diff UI wraps beyond that Max: 244 + # ignore manpage comments + IgnoredPatterns: ['#: '] Metrics/MethodLength: Max: 195 +Metrics/ModuleLength: + Max: 222 + +Metrics/PerceivedComplexity: + Max: 100 + # we won't change backward compatible method names Naming/MethodName: Exclude: