admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

cask/audit: filter bad artifacts in rosetta audit

Browse Source
This commit is contained in:
Justin Krehel 2024-06-27 12:13:31 -04:00
parent fc3ba1b495
commit 475fc1d281
No known key found for this signature in database
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/cask/audit.rb
View File

@ -570,13 +570,19 @@ module Cask
odebug "Auditing Rosetta 2 requirement" odebug "Auditing Rosetta 2 requirement"
extract_artifacts do |artifacts, tmpdir| extract_artifacts do |artifacts, tmpdir|
is_container = artifacts.any? { |a| a.is_a?(Artifact::App) || a.is_a?(Artifact::Pkg) }
artifacts.filter { |a| a.is_a?(Artifact::App) || a.is_a?(Artifact::Binary) } artifacts.filter { |a| a.is_a?(Artifact::App) || a.is_a?(Artifact::Binary) }
.each do |artifact| .each do |artifact|
next if artifact.is_a?(Artifact::Binary) && is_container
path = tmpdir/artifact.source.relative_path_from(cask.staged_path) path = tmpdir/artifact.source.relative_path_from(cask.staged_path)
result = case artifact result = case artifact
when Artifact::App when Artifact::App
files = Dir[path/"Contents/MacOS/*"] files = Dir[path/"Contents/MacOS/*"].reject do |f|
!File.executable?(f) || File.directory?(f) || f.end_with?(".dylib")
end
add_error "No binaries in App: #{artifact.source}", location: cask.url.location if files.empty? add_error "No binaries in App: #{artifact.source}", location: cask.url.location if files.empty?
system_command("lipo", args: ["-archs", files.first], print_stderr: false) system_command("lipo", args: ["-archs", files.first], print_stderr: false)
when Artifact::Binary when Artifact::Binary