From 9d2cb8e9b3fcce894e683b7b32d3d82b268668c8 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 12 Nov 2019 16:18:54 -0800 Subject: [PATCH] upgrade: don't error if already installed. I've been convinced idempotency is a good thing for this command so this would be a good thing to get out for 2.2.0. --- Library/Homebrew/cmd/upgrade.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb index 01670b03ef..c7190f5bc6 100644 --- a/Library/Homebrew/cmd/upgrade.rb +++ b/Library/Homebrew/cmd/upgrade.rb @@ -75,13 +75,13 @@ module Homebrew (ARGV.resolved_formulae - outdated).each do |f| versions = f.installed_kegs.map(&:version) if versions.empty? - onoe "#{f.full_specified_name} not installed" + ofail "#{f.full_specified_name} not installed" else version = versions.max - onoe "#{f.full_specified_name} #{version} already installed" + opoo "#{f.full_specified_name} #{version} already installed" end end - exit 1 if outdated.empty? + exit end pinned = outdated.select(&:pinned?)