SkipConditions: check disabled before deprecated

We have some formulae and casks that contain both `deprecate!` and
`disable!` calls, presumably as a way of controlling the deprecation
behavior before the disable date is reached. However, once the disable
date has been reached, `Livecheck::SkipConditions` continues to skip
the package as deprecated instead of disabled. This isn't a functional
issue as the package is still skipped but it isn't accurate because
it's not being skipped as disabled.

This reorders `FORMULA_CHECKS` and `CASK_CHECKS` to run the disabled
check before the deprecated check, so the disable date will take
precedence when it's been reached.
This commit is contained in:
Sam Ford 2025-09-02 11:32:22 -04:00
parent 75350b48a3
commit 45a642c363
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D

View File

@ -198,8 +198,8 @@ module Homebrew
FORMULA_CHECKS = T.let([
:package_or_resource_skip,
:formula_head_only,
:formula_deprecated,
:formula_disabled,
:formula_deprecated,
:formula_versioned,
].freeze, T::Array[Symbol])
private_constant :FORMULA_CHECKS
@ -207,8 +207,8 @@ module Homebrew
# Skip conditions for casks.
CASK_CHECKS = T.let([
:package_or_resource_skip,
:cask_deprecated,
:cask_disabled,
:cask_deprecated,
:cask_extract_plist,
:cask_version_latest,
:cask_url_unversioned,