From 450dcf75dc47da43e7e8276b2898a01d25418d13 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 25 Jul 2012 22:54:44 +0100 Subject: [PATCH] Fix brew doctor warnings and spurious newline. Fixes the problems discussed in 34c970 to ensure that `brew doctor` does not look like it is broken on user setup problems but still returns a sensible exit code for e.g. BrewBot. --- Library/Homebrew/cmd/doctor.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb index 25c5ec7d26..922c9ca700 100644 --- a/Library/Homebrew/cmd/doctor.rb +++ b/Library/Homebrew/cmd/doctor.rb @@ -936,9 +936,9 @@ module Homebrew extend self checks.methods.select{ |method| method =~ /^check_/ }.sort.each do |method| out = checks.send(method) unless out.nil? or out.empty? - puts unless Homebrew.failed? lines = out.to_s.split('\n') - ofail lines.shift + opoo lines.shift + Homebrew.failed = true puts lines end end